Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter to check that all common metadata is included #3419

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Linter to check that all common metadata is included #3419

merged 1 commit into from
Nov 15, 2018

Conversation

ysimonson
Copy link
Contributor

Addresses #1793

This is not ready to be merged yet. First the associated changes to cargo_metadata need to be merged: oli-obk/cargo_metadata#55

@ysimonson
Copy link
Contributor Author

ysimonson commented Nov 8, 2018 •
edited
Loading

I'm not sure what's up with the test failure. In TravisCI I'm seeing this:

+++./util/dev update_lints --check
   Compiling clippy_dev v0.0.1 (/home/travis/build/rust-lang-nursery/rust-clippy/clippy_dev)
    Finished dev [unoptimized + debuginfo] target(s) in 2.10s
     Running `target/debug/clippy_dev update_lints --check`
Not all lints defined properly. Please run `util/dev update_lints` to make sure all lints are defined properly.

Yet, when I run that locally with the latest nightly, it's a-ok:

$ util/dev update_lints
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/clippy_dev update_lints`
$ util/dev update_lints --check
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/clippy_dev update_lints --check`

@ysimonson
Copy link
Contributor Author

Ah, I see. It's made some changes that I need to commit.

oli-obk
oli-obk reviewed Nov 13, 2018
View reviewed changes
clippy_lints/Cargo.toml Outdated
@@ -17,7 +17,7 @@ keywords = ["clippy", "lint", "plugin"]
edition = "2018"

[dependencies]
cargo_metadata = "0.6"
cargo_metadata = { git = "https://github.com/ysimonson/cargo_metadata", branch = "include-all-common-metadata" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I published 0.6.2

@flip1995
Copy link
Member

bors r+

Thanks!

bors bot added a commit that referenced this pull request Nov 15, 2018
@bors @ysimonson
Merge #3419
a2c9d10 
3419: Linter to check that all common metadata is included r=flip1995 a=ysimonson

Addresses #1793

This is not ready to be merged yet. First the associated changes to `cargo_metadata` need to be merged: oli-obk/cargo_metadata#55

Co-authored-by: Yusuf Simonson <simonson@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 15, 2018

Build succeeded

@bors bors bot merged commit 866caab into rust-lang:master Nov 15, 2018
@phansch phansch mentioned this pull request Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysimonson @flip1995 @oli-obk