Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage due to rust-lang/rust#60225 #4040

Merged
merged 1 commit into from Apr 28, 2019
Merged

Fix breakage due to rust-lang/rust#60225 #4040

merged 1 commit into from Apr 28, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2019

Wrote this up before I saw that Manish already started on a fix in #4038. It no doubt contains errors. Feel free to close.

@ghost
Copy link
Author

ghost commented Apr 28, 2019

Also, if ExprKind::Use(..) creates a new scope, I think hir::map::Map::get_enclosing_scope(..) needs an update.

@Manishearth
Copy link
Member

@bors r+

I don't understand why your code works and mine doesn't (the only difference is that I use get_enclosing_scope?) but I'll take it

@bors
Copy link
Collaborator

bors commented Apr 28, 2019

📌 Commit 5ad79c2 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Apr 28, 2019

⌛ Testing commit 5ad79c2 with merge 09a0422...

bors added a commit that referenced this pull request Apr 28, 2019
Fix breakage due to rust-lang/rust#60225

Wrote this up before I saw that Manish already started on a fix in #4038. It no doubt contains errors. Feel free to close.
@bors
Copy link
Collaborator

bors commented Apr 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 09a0422 to master...

@bors bors merged commit 5ad79c2 into rust-lang:master Apr 28, 2019
@ghost ghost deleted the fix-build-20190428 branch May 11, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants