Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom ICE message that points to Clippy repo #4588

Merged
merged 8 commits into from
Nov 29, 2019
Merged

Add custom ICE message that points to Clippy repo #4588

merged 8 commits into from
Nov 29, 2019

Commits on Nov 29, 2019

  1. Add custom ICE message that points to Clippy repo 

    This utilizes rust-lang/rust#60584 by setting
our own `panic_hook` and pointing to our own issue tracker instead of
the rustc issue tracker.

This also adds a new internal lint to test the ICE message.

**Potential downsides**

* This essentially copies rustc's `report_ice` function as
  `report_clippy_ice`. I think that's how it's meant to be implemented, but
  maybe @jonas-schievink could have a look as well =)

  The downside of more-or-less copying this function is that we have to
  maintain it as well now.
  The original function can be found [here][original].
* `driver` now depends directly on `rustc` and `rustc_errors`

Closes rust-lang#2734

[original]: https://github.com/rust-lang/rust/blob/59367b074f1523353dddefa678ffe3cac9fd4e50/src/librustc_driver/lib.rs#L1185
    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    676f14b View commit details
    Browse the repository at this point in the history

  2. Use Clippy version in ICE message

    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    fc57c84 View commit details
    Browse the repository at this point in the history

  3. Update custom ICE function with latest rustc

    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    36c6a18 View commit details
    Browse the repository at this point in the history

  4. Use exec_env to set backtrace level and normalize output

    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    5029dfe View commit details
    Browse the repository at this point in the history

  5. Make triggering this lint less likely 📎

    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    ad6d8a4 View commit details
    Browse the repository at this point in the history

  6. Use rustc_env instead of exec_env for test

    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    21dee8f View commit details
    Browse the repository at this point in the history

  7. Feed the dog

    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    44eec08 View commit details
    Browse the repository at this point in the history

  8. fmt

    @phansch
    phansch committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    c1ccba0 View commit details
    Browse the repository at this point in the history