fix: uninlined_format_args shouldn't inline panic! before 2021ed #9605
Conversation
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The correct way to determine the edition of code is span.edition(). The cx.sess().opts.edition is just the default from the compiler IIRC. Since I'm already looking into it, r? @llogiq (Sorry/You're welcome Manish for stealing the review 😄 ) |
@llogiq I searched all of clippy code - the only edition usage I see anywhere is |
|
I'm not sure, it may be a relatively recent addition. |
|
@llogiq I tried this line instead, but it produces the same result. I think somehow my test is not being ran as edition2018 - can you take a look what it might be? I could try to add another file of course, but i was hoping the same file ran with multiple edition settings is a better option. if args.format_string.span.edition() < Edition2021 && is_panic(cx, def_id) { |
nyurik
force-pushed
the
fix-inline-edition
branch
from
d876352
to
74ba7e1
Compare
|
@llogiq ok, so seems like the testing framework is broken when working with multiple editions in the same file. No idea why - and not really worth digging into it -- I simply created an additional 2018 file to test specifically for the older edition. And I also used your suggestion with span.edition. Ready to be reviewed/merged :) |
| @@ -0,0 +1,23 @@ | |||
| // run-rustfix | |||
| // edition:2021 | |||
There was a problem hiding this comment.
This is the default edition, so this shouldn't be required here. But that's not keeping me from r+ing it.
|
Thank you! And yes, I remember that compiletest only lets you set the edition once per file, just as you would only be able to set the edition once per crate in your code. This is not a bug, it's an intrinsic property of the compilation model. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Fix edition revision ui tests #9605 had me wondering how the edition revision tests were working for `manual_assert` but not for `@nyurik,` but it turns out `manual_assert`'s tests weren't working either. I checked how `rust-lang/rust` does it and apparently it comes down to whitespace, `//[rev] edition:X` works 😬 Removes the revisions from `match_wild_err_arm` as I couldn't find any edition dependant behaviour there r? `@llogiq` changelog: none
uninlined_format_args: Ignore assert! and debug_assert! before 2021 edition Similar to #9605, but for `assert!` and `debug_assert!` macros. ([non_fmt_panics lint triggers them](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=18b20c408ec62a67f1503cd5d284424b)) changelog: [`uninlined_format_args`]: Do not inline `assert!` and `debug_assert!` macros before 2021 edition r? `@llogiq`
Before 2021 edition,
panic!("...")was not treated as a format string.Clippy autofix of
panic!("{}", foo)intopanic!("{foo}")is incorrect.changelog: [
uninlined_format_args]: Do not inline panic! macros before 2021 edition