Include serde_derive #99
Conversation
| version = "0.2.0" | ||
| default-features = false | ||
| features = ["serde"] | ||
| toml = { git = "https://github.com/alexcrichton/toml-rs" } |
There was a problem hiding this comment.
Serde 0.9 support exists on the master branch, update to 0.3 once it is available. toml-rs/toml-rs#137 (comment)
|
Oh dear, I've already written most / all of this locally; I certainly didn't expect you to do so! I'll give this the once-over and see what good bits I can steal 😉 |
|
I do like the idea of relying on Cargo though, would allow me to nicely sidestep toml-rs/toml-rs#142 |
|
Is there anything you are working on including in your implementation that I don't have here? If you don't have time to work on this, I can make the changes here. |
|
@dtolnay mostly just disagreements with commit sizing / grouping, so I'm in the process of splitting up your commit. I expect to make progress this evening (Eastern). |
|
Closed via #100; thanks so much! |
Fixes #82.