Skip to content

Commit

Permalink
auto merge of #19216 : Gankro/rust/bitv, r=alexcrichton
Browse files Browse the repository at this point in the history
Part of #18424

This commit changes the semantics of `reserve` and `capacity` for Bitv and BitvSet to match conventions. It also introduces the notion of `reserve_index` and `reserve_index_exact` for collections with maximum-index-based capacity semantics.

Deprecates free function constructors in favour of functions on Bitv itself.

Changes `Bitv::pop` to return an Option rather than panicking.

Deprecates and renames several methods in favour of conventions.

Marks several blessed methods as unstable.

This commit also substantially refactors Bitv and BitvSet's implementations. The new implementation is simpler, cleaner, better documented, and more robust against overflows. It also reduces coupling between Bitv and BitvSet. Tests have been seperated into seperate submodules.

Fixes #16958

[breaking-change]
  • Loading branch information
bors committed Dec 22, 2014
2 parents 2f3cff6 + 20d7a5f commit 0ac146e
Show file tree
Hide file tree
Showing 3 changed files with 970 additions and 771 deletions.
Loading

0 comments on commit 0ac146e

Please sign in to comment.