-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #49291 - tejom:check-for-known-but-incorrect-attributes…
…, r=petrochenkov Check for known but incorrect attributes fixes #43988 - Change nested_visit_map so it will recursively check functions - Add visit_stmt and visit_expr for impl Visitor for CheckAttrVisitor and check for incorrect inline and repr attributes on staements and expressions - Add regression test for issue #43988
- Loading branch information
Showing
2 changed files
with
120 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![feature(stmt_expr_attributes)] | ||
|
||
fn main() { | ||
|
||
#[inline] | ||
let _a = 4; | ||
//~^^ ERROR attribute should be applied to function | ||
|
||
|
||
#[inline(XYZ)] | ||
let _b = 4; | ||
//~^^ ERROR attribute should be applied to function | ||
|
||
#[repr(nothing)] | ||
let _x = 0; | ||
//~^^ ERROR attribute should not be applied to a statement | ||
|
||
#[repr(something_not_real)] | ||
loop { | ||
() | ||
}; | ||
//~^^^^ ERROR attribute should not be applied to an expression | ||
|
||
#[repr] | ||
let _y = "123"; | ||
//~^^ ERROR attribute should not be applied to a statement | ||
|
||
|
||
fn foo() {} | ||
|
||
#[inline(ABC)] | ||
foo(); | ||
//~^^ ERROR attribute should be applied to function | ||
|
||
let _z = #[repr] 1; | ||
//~^ ERROR attribute should not be applied to an expression | ||
|
||
} |