Skip to content

Commit

Permalink
Auto merge of #113450 - Nilstrieb:src/bootstrap/test.rs, r=flip1995
Browse files Browse the repository at this point in the history
Fail the build if clippy tests don't pass

This was removed in
de69d55#diff-8479eab02701e686aedb15b567dc8fc31220c6e4efb9565ccc9d662b7fee2214 which caused CI to ignore clippy failures. This adds back the exit, which should cause CI to fail again if a test is broken (like right now, as clippy tests are broken on master).

Also see https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/CI.20doesn't.20care.20about.20clippy.20test.20failures.20but.20only.20sometime

r? flip1995
  • Loading branch information
bors committed Jul 8, 2023
2 parents 9bb6fbe + d8c29b8 commit 4353b1e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 19 deletions.
4 changes: 4 additions & 0 deletions src/bootstrap/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,10 @@ impl Step for Clippy {
// The tests succeeded; nothing to do.
return;
}

if !builder.config.cmd.bless() {
crate::detail_exit_macro!(1);
}
}
}

Expand Down

This file was deleted.

This file was deleted.

0 comments on commit 4353b1e

Please sign in to comment.