Skip to content

Commit

Permalink
Mark crate_inherent_impls as eval_always.
Browse files Browse the repository at this point in the history
This is global query, so it will probably be invalidated anyway.

This was creating a compound dependency from any typeck to any hir_owner:
typeck -> incoherent_impls -> crate_incoherent_impls ->
crate_inherent_impls -> hir_owner.

This dependency was (incorrectly?) flagged by the ui/dep-graph tests as
problematic.
  • Loading branch information
cjgillot committed Apr 30, 2022
1 parent f8ee1e0 commit 44bc150
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions compiler/rustc_middle/src/query/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,7 @@ rustc_queries! {
/// Not meant to be used directly outside of coherence.
query crate_inherent_impls(k: ()) -> CrateInherentImpls {
storage(ArenaCacheSelector<'tcx>)
eval_always
desc { "all inherent impls defined in crate" }
}

Expand Down

0 comments on commit 44bc150

Please sign in to comment.