Skip to content

Commit

Permalink
Rollup merge of #73097 - Mark-Simulacrum:clippy-fail, r=oli-obk
Browse files Browse the repository at this point in the history
Try_run must only be used if toolstate is populated

Clippy's tests were failing the build, but that failure was ignored in favor of checking toolstate. This is the correct behavior for toolstate-checked tools, but Clippy no longer updates its toolstate status as it should always build.

The previous PR of this kind didn't catch this as I expected x.py failures to always lead to a non-successful build in CI, but that's not the case specifically for tool testing.
  • Loading branch information
Dylan-DPC committed Jun 11, 2020
2 parents 80fce36 + 6f01576 commit 8d62099
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/bootstrap/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ impl Step for Clippy {

builder.add_rustc_lib_path(compiler, &mut cargo);

try_run(builder, &mut cargo.into());
builder.run(&mut cargo.into());
}
}

Expand Down

0 comments on commit 8d62099

Please sign in to comment.