Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc-Json: Add ResolvedPath type #100106

Closed
aDotInTheVoid opened this issue Aug 3, 2022 · 1 comment · Fixed by #100335
Closed

Rustdoc-Json: Add ResolvedPath type #100106

aDotInTheVoid opened this issue Aug 3, 2022 · 1 comment · Fixed by #100335
Assignees
@aDotInTheVoid
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

aDotInTheVoid commented Aug 3, 2022 •
edited by rustbot
Loading

We don't yet have a ResolvedPath type in the json output, so I think that should be done in a followup change, as theirs a couple of other places we'd also want to use it (

rust/src/librustdoc/json/conversions.rs

Line 423 in e141246

// FIXME: should `trait_` be a clean::Path equivalent in JSON?
,

rust/src/librustdoc/json/conversions.rs

Line 500 in e141246

let trait_ = clean::Type::Path { path: trait_ }.into_tcx(tcx);
)

Originally posted by @aDotInTheVoid in #99787 (comment)

@rustbot modify labels: +T-rustdoc +A-rustdoc-json
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 3, 2022
@aDotInTheVoid
Copy link
Member Author

@rustbot claim

@aDotInTheVoid aDotInTheVoid mentioned this issue Aug 9, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Aug 13, 2022
@Dylan-DPC
Rollup merge of rust-lang#100335 - aDotInTheVoid:rdj-resolved-path, r…
b7a020f 
…=GuillaumeGomez

Rustdoc-Json: Add `Path` type for traits.

Avoids using `Type` for trait fields, as a trait must always be a path, and not any other kind of type.

`@rustbot` modify labels: +A-rustdoc-json +T-rustdoc

Closes rust-lang#100106
compiler-errors added a commit to compiler-errors/rust that referenced this issue Aug 14, 2022
@compiler-errors
Rollup merge of rust-lang#100335 - aDotInTheVoid:rdj-resolved-path, r…
4989f6a 
…=GuillaumeGomez

Rustdoc-Json: Add `Path` type for traits.

Avoids using `Type` for trait fields, as a trait must always be a path, and not any other kind of type.

``@rustbot`` modify labels: +A-rustdoc-json +T-rustdoc

Closes rust-lang#100106
@bors bors closed this as completed in 86bdb3e Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aDotInTheVoid aDotInTheVoid

Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rustdoc-Json: Add Path type for traits. aDotInTheVoid/rust
2 participants
@aDotInTheVoid @rustbot