Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should "system" ABI be "win64" on x86_64 windows? #11261

Closed
brson opened this issue Jan 1, 2014 · 4 comments
Closed

Should "system" ABI be "win64" on x86_64 windows? #11261

brson opened this issue Jan 1, 2014 · 4 comments
Labels
O-windows Operating system: Windows P-low Low priority

Comments

@brson
Copy link
Contributor

brson commented Jan 1, 2014

I don't know anything about the windows ABI, but this seems plausible.
@brson brson mentioned this issue Aug 12, 2014
Closed
33 tasks
@klutzy
Copy link
Contributor

klutzy commented Aug 14, 2014

On win64 LLVM treats extern "C" as same as extern "win64", so current status (extern "system" is extern "C") is okay.
(We have explicit notion of "win64" only because the calling convention is also used in uefi.)

@pnkfelix
Copy link
Member

From the evidence we have so far, it sounds like the behavior is going to stay the same from the point of view of the programmer, though we may change the underlying implmentation.

P-low, not 1.0.

@vadimcn
Copy link
Contributor

vadimcn commented Aug 30, 2014

@brson, I don't quite understand the question you are posing here. Win64 has only one calling convention, so "system" == "C" == "win64".

@brson
Copy link
Contributor Author

brson commented Sep 12, 2014

Seems like whether we treat 'system' as 'C' or 'win64' is just an internal detail. Closing.

@brson brson closed this as completed Sep 12, 2014
@GabrielMajeri GabrielMajeri mentioned this issue Sep 24, 2018
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 31, 2023
@bors
Auto merge of rust-lang#11261 - y21:issue11260, r=blyxyas
2ab1241 
[`unnecessary_find_map`]: look for then_some

Closes rust-lang#11260

changelog: [`unnecessary_find_map`]: lint `.then_some()` in closure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows P-low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brson @pnkfelix @klutzy @vadimcn