Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for RFC #572: feature gate unused attributes #22203

Closed
nrc opened this issue Feb 12, 2015 · 5 comments · Fixed by #22364
Closed

Tracking issue for RFC #572: feature gate unused attributes #22203

nrc opened this issue Feb 12, 2015 · 5 comments · Fixed by #22364
Assignees
@pnkfelix
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. P-medium Medium priority
Milestone
1.0 beta

Comments

@nrc
Copy link
Member

nrc commented Feb 12, 2015

No description provided.

@nrc nrc added I-nominated B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Feb 12, 2015
@nrc nrc mentioned this issue Feb 12, 2015
Merged
@nrc
Copy link
Member Author

nrc commented Feb 12, 2015

RFC

@pnkfelix
Copy link
Member

1.0 beta, P-high.

@pnkfelix pnkfelix added this to the 1.0 beta milestone Feb 12, 2015
@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Feb 12, 2015
@pnkfelix pnkfelix self-assigned this Feb 12, 2015
@nrc
Copy link
Member Author

nrc commented Feb 13, 2015

@Manishearth (the RFC author) is going to implement (also happy to mentor anyone else who wants to do it).

@Manishearth
Copy link
Member

I've started implementing it (mostly need to fix tests now)

@nikomatsakis
Copy link
Contributor

In the meantime I opened a PR for a simple-minded feature-gate for attributes starting in rustc_, just to avoid undue dependency on the misc testing attributes we have. This will be superceded (or at minimum rendered superfluous) by @Manishearth's implementation, of course. (Though it doesn't hurt either.) PR is #22336

@Manishearth Manishearth mentioned this issue Feb 15, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 16, 2015
@Manishearth
Feature gate custom attributes (fixes rust-lang#22203)
38542cc
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 17, 2015
@Manishearth
Rollup merge of rust-lang#22364 - Manishearth:rfc-572-forbid-attr, r=…
4647d89 
…nikomatsakis

 fixes rust-lang#22203

r? @nikomatsakis

This breaks code that might be using attributes randomly, so it's technically a

[breaking-change]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. P-medium Medium priority
Projects
None yet
Milestone
1.0 beta
Development

Successfully merging a pull request may close this issue.

Feature gate custom attributes Manishearth/rust
4 participants
@nikomatsakis @pnkfelix @nrc @Manishearth