Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special comment to indicate work that is pending a snapshot #2483

Closed
nikomatsakis opened this issue Jun 1, 2012 · 4 comments
Closed

special comment to indicate work that is pending a snapshot #2483

nikomatsakis opened this issue Jun 1, 2012 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@nikomatsakis
Copy link
Contributor

We should add some sort of special comment like // PENDING SNAPSHOT abcdef. Here abcdef is the hashcode of the current snapshot. The build system can then issue warnings if such a comment exists and abcdefis not still the current snapshot.

@bstrie
Copy link
Contributor

bstrie commented Apr 29, 2013

@nikomatsakis, do you still feel that this would be useful?

@nikomatsakis
Copy link
Contributor Author

Still seems useful to me.

@emberian
Copy link
Member

Still very useful.

@catamorphism
Copy link
Contributor

(bug triage) This would be nice, but is not a blocker.

celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

4 participants