Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FromStr for SocketAddrV4 and SocketAddrV6 #29183

Closed
canndrew opened this issue Oct 20, 2015 · 0 comments
Closed

Implement FromStr for SocketAddrV4 and SocketAddrV6 #29183

canndrew opened this issue Oct 20, 2015 · 0 comments

Comments

@canndrew
Copy link
Contributor

I need to parse an ipv4 address. I feel like these impls are missing seeing as we have impls of FromStr for SocketAddr, Ipv4Addr and Ipv6Addr.
alexcrichton added a commit to alexcrichton/rust that referenced this issue Oct 20, 2015
@alexcrichton
std: Implement FromStr for SocketAddrV{4,6}
8aa6a11 
This was already implemented for SocketAddr, so the other types are lacking it
is just an oversight!

Closes rust-lang#29183
@alexcrichton alexcrichton mentioned this issue Oct 20, 2015
Merged
bors added a commit that referenced this issue Oct 21, 2015
@bors
Auto merge of #29190 - alexcrichton:from-str-socket-addr, r=brson
ff5cc89 
This was already implemented for SocketAddr, so the other types are lacking it
is just an oversight!

Closes #29183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@canndrew