Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: str::split_at_mut() example wrong #32933

Closed
bungcip opened this issue Apr 13, 2016 · 5 comments
Closed

documentation: str::split_at_mut() example wrong #32933

bungcip opened this issue Apr 13, 2016 · 5 comments

Comments

@bungcip
Copy link
Contributor

bungcip commented Apr 13, 2016

it seem example in https://doc.rust-lang.org/std/primitive.str.html#method.split_at_mut
is duplicate of str::split_at() example

@GuillaumeGomez
Copy link
Member

Indeed. Want to fix it?

@bungcip
Copy link
Contributor Author

bungcip commented Apr 13, 2016

Sure, but I will need to clone & learn how to build rust from source tough. I hope my notebook is not too slow to compile it :).

@bluss
Copy link
Member

bluss commented Apr 13, 2016

Go ahead and fix. But for this small thing I would probably not build rust locally at all. Make sure the code compiles in a simpler environment, and then let the test builders take care of it?

@GuillaumeGomez
Copy link
Member

Just like @bluss said, no need to build anything. Just modify the comment in the rustc source code and open a PR.

steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 14, 2016
fix str::split_at_mut() example

fix documentation issue rust-lang#32933
@tbu-
Copy link
Contributor

tbu- commented May 30, 2016

Fixed by #32941.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants