E0061 needs to be updated to new format

[sophiajt]

From: src/test/compile-fail/E0061.rs

Error E0061 needs a span_label, updating it from:

error[E0061]: this function takes 2 parameters but 1 parameter was supplied
  --> src/test/compile-fail/E0061.rs:14:5
   |
14 |     f(0); //~ ERROR E0061
   |     ^^^^
   |
   = note: the following parameter types were expected: u16, &str

error: aborting due to previous error

To:

error[E0061]: this function takes 2 parameters but 1 parameter was supplied
  --> src/test/compile-fail/E0061.rs:14:5
   |
14 |     f(0); //~ ERROR E0061
   |     ^^^^ expected 2 parameters
   |
   = note: the following parameter types were expected: u16, &str

error: aborting due to previous error

Bonus: the types could be incorporated into the label rather than a note (though we may want to avoid types with long names in the label)

[jaredwy]

Planning on tackling the bonus here. Is there a prefered max length for output on the console. In the case it would exceed this should i truncate the typename or just not include?

[sophiajt]

@jaredwy - great point. If you want to work on truncation, feel free to add it, too. I'm not sure if the term crate will tell you the current terminal size, but it may.

[leikahing]

I'm fixing #35215 and I noticed that it and this issue currently share the same code for generating this error, and adding code to add a span_label to the message in librustc_typeck/check/mod.rs would fix both.

[jaredwy]

Did you do the bonus as well? I can tackle that if you haven't.

[leikahing]

@jaredwy I haven't yet - I can fix the span_label issue (currently testing/fixing unit tests) and you can take on the bonus part of the issue.

[jaredwy]

Sounds great to me! Thanks.

[leikahing]

@jaredwy - I opened up issue #35290 to track the bonus portion of the work for you.