rustbuild: target.*.musl-root in config.toml is ignored #38058
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
japaric
added
the
T-bootstrap
|
Ah yes that's newer and should be preferred. I think I ran into this awhile ago as well. I think there's a bug in rustbuild to ignore the x86_64 default if musl-root is specified, but we could also just stop documenting |
bors
added a commit
that referenced
this issue
Aug 28, 2017
…crum rustbuild: Rewrite the configure script in Python This commit rewrites our ancient `./configure` script from shell into Python. The impetus for this change is to remove `config.mk` which is just a vestige of the old makefile build system at this point. Instead all configuration is now solely done through `config.toml`. The python script allows us to more flexibly program (aka we can use loops easily) and create a `config.toml` which is based off `config.toml.example`. This way we can preserve comments and munge various values as we see fit. It is intended that the configure script here is a drop-in replacement for the previous configure script, no functional change is intended. Also note that the rationale for this is also because our build system requires Python, so having a python script a bit earlier shouldn't cause too many problems. Closes #40730 Closes #43295 Closes #42255 Closes #38058 Closes #32176
bors
added a commit
that referenced
this issue
Aug 28, 2017
…crum rustbuild: Rewrite the configure script in Python This commit rewrites our ancient `./configure` script from shell into Python. The impetus for this change is to remove `config.mk` which is just a vestige of the old makefile build system at this point. Instead all configuration is now solely done through `config.toml`. The python script allows us to more flexibly program (aka we can use loops easily) and create a `config.toml` which is based off `config.toml.example`. This way we can preserve comments and munge various values as we see fit. It is intended that the configure script here is a drop-in replacement for the previous configure script, no functional change is intended. Also note that the rationale for this is also because our build system requires Python, so having a python script a bit earlier shouldn't cause too many problems. Closes #40730 Closes #43295 Closes #42255 Closes #38058 Closes #32176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AFAICT, the
CFG_MUSL_ROOT_X86_64"variable" in theconfig.mkfile thatconfiguregenerates overrides thetarget.x86_64-unknown-linux-musl.musl-rootsetting inconfig.toml. I think the precedence should be the other way around.cc @alexcrichton is
CFG_MUSL_ROOT_X86_64new-ish?The text was updated successfully, but these errors were encountered: