Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for needs_drop #41890

Closed
Gankra opened this issue May 10, 2017 · 5 comments · Fixed by #44639
Closed

Tracking Issue for needs_drop #41890

Gankra opened this issue May 10, 2017 · 5 comments · Fixed by #44639
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Gankra
Copy link
Contributor

Gankra commented May 10, 2017

About to submit a PR for exposing intrinsics::needs_drop under mem. Needs a tracking issue.

Here it is!

@nagisa nagisa added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 11, 2017
@nagisa
Copy link
Member

nagisa commented May 11, 2017

The PR is #41892

@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 22, 2017
@alexcrichton
Copy link
Member

@rfcbot fcp merge

Seems like this may be good to stabilize!

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Aug 29, 2017
@rfcbot
Copy link

rfcbot commented Aug 29, 2017

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link

rfcbot commented Sep 5, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 5, 2017
@rfcbot
Copy link

rfcbot commented Sep 15, 2017

The final comment period is now complete.

budziq added a commit to budziq/rust that referenced this issue Sep 16, 2017
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
TimNN added a commit to TimNN/rust that referenced this issue Sep 17, 2017
dtolnay pushed a commit to dtolnay/rust that referenced this issue Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants