Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove check-fast driver #4193

Closed
brson opened this issue Dec 15, 2012 · 4 comments
Closed

remove check-fast driver #4193

brson opened this issue Dec 15, 2012 · 4 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Dec 15, 2012

It's not compatible with the new import resolution rules.
@brson
Copy link
Contributor Author

brson commented Mar 12, 2013

It's also causing us to have continuous, repeated windows bustage from not running the full test suite.

@pcwalton
Copy link
Contributor

pcwalton commented May 9, 2013

Yes

@emberian
Copy link
Member

Still relevent, still frequently breaking. Is it worth the perf hit for windows though?

@emberian emberian mentioned this issue Jul 12, 2013
Closed
This was referenced Aug 29, 2013
Closed
Closed
@metajack
Copy link
Contributor

Triage bump.

brson added a commit to brson/rust that referenced this issue Feb 25, 2014
@brson
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
b2bb2f5 
, rust-lang#7416
brson added a commit to brson/rust that referenced this issue Mar 22, 2014
@brson
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
769c4ea 
, rust-lang#7416
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Apr 5, 2014
@brson @alexcrichton
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
ae5da74 
, rust-lang#7416
@brson brson closed this as completed in 072a920 Apr 7, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 30, 2021
@bors
Auto merge of rust-lang#6591 - camsteffen:manual-filter-map, r=llogiq
3c3f4a7 
`manual_filter_map` and `manual_find_map`

changelog: Add `manual_filter_map` and replace `find_map` with `manual_find_map`

Replaces rust-lang#6453

Fixes rust-lang#3188
Fixes rust-lang#4193

~Depends on rust-lang#6567 (to fix an internal lint false positive)~

This replaces `filter_map` and `find_map` with `manual_filter_map` and `manual_find_map` respectively. However, `filter_map` is left in place since it is used for a variety of other cases. See discussion in rust-lang#6453.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@metajack @brson @pcwalton @emberian