add thiscall calling convention #42044
Comments
|
cc @emilio |
|
See also rust-lang/rfcs#1342 |
|
So, uh, we should just do this, then? 😁 |
froydnj
added a commit
to froydnj/rust
that referenced
this issue
May 24, 2017
This support is needed for bindgen to work well on 32-bit Windows, and also enables people to begin experimenting with C++ FFI support on that platform. Fixes rust-lang#42044.
bors
added a commit
that referenced
this issue
May 26, 2017
add thiscall calling convention support This support is needed for bindgen to work well on 32-bit Windows, and also enables people to begin experimenting with C++ FFI support on that platform. Fixes #42044.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Trying to get servo/rust-bindgen working with win32 today, I ran into rust-lang/rust-bindgen#541, where the
__thiscallcalling convention wasn't supported in bindgen. (My use of bindgen doesn't actually generate calls to__thiscallfunctions, but the function representations need to support__thiscallAFAICT.) Tracing back through the stack, it's not supported insyntex_syntax, and adding that support is AFAICT tricky until it's supported by rustc in some way.Adding
__thiscallwas already proposed in #37 and/or #5853, but tangled up in much grander plans about FFI interfaces; this bug is more narrowly scoped to just adding support for the calling convention. People can then experiment with it via bindgen and nightly Rust. In this way, I think it's essentially like the existing support forvectorcall.I think it's straightforward to do the work and am happy to sign up for doing it, but I'd like to know if there are strenuous objections to doing so.
The text was updated successfully, but these errors were encountered: