Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach .pkg, .msi, .exe installers about RLS #42157

Closed
brson opened this issue May 22, 2017 · 7 comments
Closed

Teach .pkg, .msi, .exe installers about RLS #42157

brson opened this issue May 22, 2017 · 7 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@brson
Copy link
Contributor

brson commented May 22, 2017

RLS can be installed via rustup, but not the other methods yet. We really can't claim RLS is released without.

I'm putting this on the 1.19 milestone because I don't see it being fixed in 1.18 at this point.

cc @nrc
@brson brson added this to the 1.19 milestone May 22, 2017
@brson brson added the E-help-wanted Call for participation: Help is requested to fix this issue. label May 22, 2017
@brson
Copy link
Contributor Author

brson commented May 22, 2017 •
edited
Loading

Help would be appreciated for any of the three packaging solutions. RLS should be a non-default component.

The code responsible for packaging starts in in src/bootstrap/dist.rs

@brson brson mentioned this issue May 22, 2017
Closed
@efyang
Copy link
Contributor

efyang commented May 24, 2017

So if I'm looking at this right the main files that would need to be changed are src/bootstrap/dist.rs and the manifests in src/etc/installer/. Could I try taking up this issue?

@o01eg
Copy link
Contributor

o01eg commented May 24, 2017

Can it be related to gentoo/gentoo-rust#255 ?

@efyang
Copy link
Contributor

efyang commented May 29, 2017 •
edited
Loading

Would it make more sense to have the analysis module be a child "feature" of the RLS or just entirely bundled with the RLS? @brson

@efyang efyang mentioned this issue May 30, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 1, 2017
@frewsxcv
Rollup merge of rust-lang#42306 - efyang:rls-packaging, r=alexcrichton
b517eb0 
Add the RLS to .exe, .msi, and .pkg installers

This directly addresses issue rust-lang#42157, adding the RLS as a non-default component in the mentioned installers. The windows installers appear to have the right functionality added, but I don't have a machine that runs OSX, so it would be great if someone could test whether my .pkg commit adds the RLS correctly. The final commit also fixes some formatting issues I'd noticed while working on the installers, but I don't know if that's within the scope of this PR, so input would be appreciated.
frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 1, 2017
@frewsxcv
Rollup merge of rust-lang#42306 - efyang:rls-packaging, r=alexcrichton
2221f9c 
Add the RLS to .exe, .msi, and .pkg installers

This directly addresses issue rust-lang#42157, adding the RLS as a non-default component in the mentioned installers. The windows installers appear to have the right functionality added, but I don't have a machine that runs OSX, so it would be great if someone could test whether my .pkg commit adds the RLS correctly. The final commit also fixes some formatting issues I'd noticed while working on the installers, but I don't know if that's within the scope of this PR, so input would be appreciated.
@nagisa
Copy link
Member

nagisa commented Jun 1, 2017 •
edited
Loading

Why not just ship two installers?

EDIT: oh, I see it is non-default component already. Shrugs.

@brson brson removed this from the 1.19 milestone Jun 1, 2017
@brson brson mentioned this issue Jun 1, 2017
Closed
@brson
Copy link
Contributor Author

brson commented Jun 1, 2017

Thanks so much for tackling all three of them @efyang!

Sadly we're going to need to revert temporarily per #42357 until we make some more decisions about how we want to message rls stability. RLS is not going to happen for 1.19.

@Mark-Simulacrum Mark-Simulacrum added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jul 27, 2017
@alexcrichton
Copy link
Member

Tis was done awhile ago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@alexcrichton @brson @o01eg @nagisa @Mark-Simulacrum @efyang