Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend 'unimplemented!' API docs to mention new parameter functionality #42628

Closed
frewsxcv opened this issue Jun 13, 2017 · 5 comments
Closed

Extend 'unimplemented!' API docs to mention new parameter functionality #42628

frewsxcv opened this issue Jun 13, 2017 · 5 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority

Comments

@frewsxcv
Copy link
Member

Follow-up to #42155
@frewsxcv frewsxcv added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jun 13, 2017
@frewsxcv frewsxcv changed the title Extened 'unimplemented!' API docs to mention new parameter functionality Extend 'unimplemented!' API docs to mention new parameter functionality Jun 20, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 27, 2017
@steveklabnik steveklabnik added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority labels Aug 30, 2017
@steveklabnik
Copy link
Member

I'd be happy to mentor anyone who wants to take this on! It mostly involves adding a small example to the docs, a great first issue!

@MarkMcCaskey
Copy link
Contributor

@steveklabnik I'd be interested! Thanks!

@MarkMcCaskey MarkMcCaskey mentioned this issue Aug 31, 2017
Merged
@toidiu
Copy link
Contributor

toidiu commented Sep 6, 2017

@MarkMcCaskey are you still working on this?

@kennytm
Copy link
Member

kennytm commented Sep 6, 2017 •
edited
Loading

@toidiu "initial changes" implemented as #44206, currently waiting to be merged.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Sep 6, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44206 - MarkMcCaskey:master, r=steveklabnik
0420654 
update unimplemented! docs

For rust-lang#42628 (updating docs from changes from rust-lang#42155).

Initial changes made to make `unimplemented!` doc comments look more like `unreachable!` and remove statement about the panic message.

r? @steveklabnik
@toidiu
Copy link
Contributor

toidiu commented Sep 6, 2017

@kennytm oops sry missed that

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44206 - MarkMcCaskey:master, r=steveklabnik
b8812a2 
update unimplemented! docs

For rust-lang#42628 (updating docs from changes from rust-lang#42155).

Initial changes made to make `unimplemented!` doc comments look more like `unreachable!` and remove statement about the panic message.

r? @steveklabnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@steveklabnik @kennytm @frewsxcv @toidiu @Mark-Simulacrum @MarkMcCaskey