Tracking issue for HashMap::remove_entry #46344
Labels
B-unstable
Blocker: Implemented in the nightly compiler and unstable.
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
final-comment-period
In the final comment period and will be merged soon unless new substantive objections are raised.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
sfackler
changed the title
sfackler
added
B-unstable
|
Should we also add |
kennytm
pushed a commit
to kennytm/rust
that referenced
this issue
Jan 8, 2018
Implements rust-lang#46344
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Jan 8, 2018
Add HashMap::remove_entry Implements rust-lang#46344 r? @dtolnay
XAMPPRocky
added
the
C-enhancement
|
Looks good to me to stabilize. @rfcbot fcp merge |
|
Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
the
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
final-comment-period
21 tasks
|
The final comment period is now complete. |
bors
added a commit
that referenced
this issue
Apr 18, 2018
stabilize a bunch of minor api additions besides `ptr::NonNull::cast` (which is 4 days away from end of FCP) all of these have been finished with FCP for a few weeks now with minimal issues raised * Closes #41020 * Closes #42818 * Closes #44030 * Closes #44400 * Closes #46507 * Closes #47653 * Closes #46344 the following functions will be stabilized in 1.27: * `[T]::rsplit` * `[T]::rsplit_mut` * `[T]::swap_with_slice` * `ptr::swap_nonoverlapping` * `NonNull::cast` * `Duration::from_micros` * `Duration::from_nanos` * `Duration::subsec_millis` * `Duration::subsec_micros` * `HashMap::remove_entry`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We added this to OccupiedEntry a while ago, but weirdly not to the map itself.
The text was updated successfully, but these errors were encountered: