Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly sort results in a getopts test #4681

Closed
catamorphism opened this issue Jan 30, 2013 · 2 comments
Closed

Possibly sort results in a getopts test #4681

catamorphism opened this issue Jan 30, 2013 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

A comment in test_groups_getopts in std::getopts said to sort the two option sets. I gave up upon realizing they're not just vectors of something easily sortable.
@msullivan
Copy link
Contributor

Cleanup, but not really important. Not milestoning.

@bblum
Copy link
Contributor

bblum commented Aug 19, 2013

Still cleanup, still not really important. Still not milestoning.

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5129 - JohnTitor:use-checked-sub, r=flip1995
a395894 
Use `checked_sub` to avoid index out of bounds

(Fixes) rust-lang#4681 (possibly)

The issue likely occurs due to `lit_snip.len() < suffix.len() + 1`. You can see similar backtrace to change it to `lit_snip.len() - suffix.len() - 1000` or something then run `cargo test --release`.
But I couldn't come up with the test so I'd leave the issue open if we want.

changelog: Fix potential ICE in `misc_early`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msullivan @catamorphism @bblum