Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot type letter 's' into search box in Nightly Rust Doc [1.26.0-nightly (392645394 2018-03-15)] #49075

Closed
OnlyLys opened this issue Mar 16, 2018 · 6 comments
Closed

Cannot type letter 's' into search box in Nightly Rust Doc [1.26.0-nightly (392645394 2018-03-15)] #49075

OnlyLys opened this issue Mar 16, 2018 · 6 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@OnlyLys
Copy link

OnlyLys commented Mar 16, 2018 •
edited
Loading

Issue

The search box in the latest nightly std documentation does not allow the letter 's' to be entered into it.

Both the local copy available via rustup doc and the online one available at https://doc.rust-lang.org/nightly/std are affected. This problem happens on Chrome Beta, Firefox and Edge.

Note

The stable documentation [Version 1.24.1 (d3ae9a9 2018-02-27)] does not have this issue. Neither does the beta documentation [Version 1.25.0-beta.10 (de97991 2018-03-13)].

I also tested the previous nightly (nightly-2018-03-07) and at least for the local copy of the doc, it did not have this issue. Therefore it must be the latest nightly that broke the search box.
@kennytm kennytm added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. labels Mar 16, 2018
@mzji
Copy link

mzji commented Mar 17, 2018

Looks like 9e0ccc5 is the culprit, @GuillaumeGomez ...

@mzji
Copy link

mzji commented Mar 17, 2018 •
edited
Loading

Temp fix: RUSTUP_BASE_DIR/toolchains/YOUR_TOOLCHAIN_TRIPLE/share/doc/rust/html/main.js Line 243:

-        if (document.activeElement.tagName === "INPUT" &&
+        if (document.activeElement.tagName === "INPUT" ||

Then both s and ? back to work.

@kennytm kennytm mentioned this issue Mar 17, 2018
Closed
@GuillaumeGomez
Copy link
Member

Oh damn, indeed!

@OnlyLys
Copy link
Author

OnlyLys commented Mar 18, 2018

@mzji Yes that works! Thank you!

@GuillaumeGomez
Copy link
Member

No, the fix breaks why it has been implemented first. It fixes this issue, but not why I made this change. I need to look further.

@GuillaumeGomez
Copy link
Member

Ok, fix done. I'll make the PR this evening.

@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 18, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Mar 20, 2018
@kennytm
Rollup merge of rust-lang#49152 - GuillaumeGomez:rustdoc-event-handli…
45de057 
…ng, r=QuietMisdreavus

Fix events handling in rustdoc

Fixes rust-lang#49075.
@ruuda ruuda mentioned this issue Apr 18, 2018
Closed
@ivanovaleksey ivanovaleksey mentioned this issue Apr 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kennytm @GuillaumeGomez @mzji @OnlyLys