Rename CodeMap/FileMap to SourceMap/SourceFile.

[eddyb]

The name FileMap always seemed a bit jarring, and I think this would be an improvement.
cc @nikomatsakis @nrc

[abhijeetbhagat]

I can take this up.

[abhijeetbhagat]

What about structs like FileMapAndLine ?

[eddyb]

@abhijeetbhagat SourceFileAndLine looks fine to me.

[dsciarra]

should the module codemap also be renamed?

[eddyb]

Yeah, any combination of the words "code" and "map" should.

[abhijeetbhagat]

Right. Changing that too.

[jolson88]

With the merge, it's unclear to me whether this is an older issue that needs closing, or if there is more work to do. A quick search seems to show the following occurences still:

• MalformedForCodemap and MalformedCodemapPositions in src/libsyntax_pos/lib.rs and src/libsyntax/source_map.rs
• pub use self::caching_codemap_view::CachingSourceMapView in src/librustc/ich/mod.rs
• StableFilemapId in src/libsyntax/source_map.rs

If this issue is still considered open, does that reflect that that these should be renamed as well?

• MalformedForCodemap -> MalformedForSourceMap
• MalformedCodemapPositions -> MalformedSourceMapPositions
• self::caching_codemap_view -> self::caching_source_map_view
• StableFilemapId -> StableSourceFileId

[eddyb]

I assume this is done after #55190?

[eddyb]

I came across over this instance of cm today:

rust/src/librustc_errors/lib.rs

Line 149 in e6ec0d1

pub fn splice_lines(&self, cm: &SourceMap) -> Vec<(String, Vec<SubstitutionPart>, bool)> {

So we might need to do another pass just for easier to miss things like cm.

[Alexendoo]

Looks done after #69375