Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary stability attributes for const fn #56585

Closed
jethrogb opened this issue Dec 7, 2018 · 0 comments · Fixed by #56708
Closed

Remove unnecessary stability attributes for const fn #56585

jethrogb opened this issue Dec 7, 2018 · 0 comments · Fixed by #56708
Assignees
@oli-obk
Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. A-stability Area: issues related to #[stable] and #[unstable] attributes themselves.

Comments

@jethrogb
Copy link
Contributor

jethrogb commented Dec 7, 2018 •
edited
Loading

In 8d6edc9 various stability attributes were added to functions that are not public. This was required to satisfy the min_const_fn checker. The lines in question all contain FIXME: min_const_fn. @oli-obk volunteered to take a look.

You should be able to test this build with a somewhat-recent nightly and

cargo +nightly check --target x86_64-fortanix-unknown-sgx --manifest-path src/libstd/Cargo.toml
@oli-obk oli-obk self-assigned this Dec 7, 2018
@oli-obk oli-obk added A-stability Area: issues related to #[stable] and #[unstable] attributes themselves. A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. labels Dec 7, 2018
@oli-obk oli-obk mentioned this issue Dec 11, 2018
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Dec 11, 2018
@pietroalbini
Rollup merge of rust-lang#56708 - oli-obk:stability_internal_const_fn…
31550ff 
…, r=alexcrichton

Remove some unnecessary feature gates

fixes rust-lang#56585

cc @jethrogb
kennytm added a commit to kennytm/rust that referenced this issue Dec 12, 2018
@kennytm
Rollup merge of rust-lang#56708 - oli-obk:stability_internal_const_fn…
3377af6 
…, r=alexcrichton

Remove some unnecessary feature gates

fixes rust-lang#56585

cc @jethrogb
kennytm added a commit to kennytm/rust that referenced this issue Dec 13, 2018
@kennytm
Rollup merge of rust-lang#56708 - oli-obk:stability_internal_const_fn…
070443b 
…, r=alexcrichton

Remove some unnecessary feature gates

fixes rust-lang#56585

cc @jethrogb
kennytm added a commit to kennytm/rust that referenced this issue Dec 14, 2018
@kennytm
Rollup merge of rust-lang#56708 - oli-obk:stability_internal_const_fn…
33a94f1 
…, r=alexcrichton

Remove some unnecessary feature gates

fixes rust-lang#56585

cc @jethrogb
kennytm added a commit to kennytm/rust that referenced this issue Dec 14, 2018
@kennytm
Rollup merge of rust-lang#56708 - oli-obk:stability_internal_const_fn…
27c3631 
…, r=alexcrichton

Remove some unnecessary feature gates

fixes rust-lang#56585

cc @jethrogb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

Labels
A-const-fn Area: const fn foo(..) {..}. Pure functions which can be applied at compile time. A-stability Area: issues related to #[stable] and #[unstable] attributes themselves.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove some unnecessary feature gates oli-obk/rust
2 participants
@oli-obk @jethrogb