Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack overflow while compiling gleam crate #58319

Closed
staktrace opened this issue Feb 9, 2019 · 2 comments · Fixed by #70176
Closed

Stack overflow while compiling gleam crate #58319

staktrace opened this issue Feb 9, 2019 · 2 comments · Fixed by #70176
Labels
C-bug Category: This is a bug. E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@staktrace
Copy link
Contributor

staktrace commented Feb 9, 2019 •
edited
Loading

A number of people have run into a stack overflow in rustc when compiling the gleam crate, see servo/gleam#180 - I can reproduce this in a relatively controlled environment on Mozilla's macOS automation. Here is a log attempting to compile wrench which is dependent on gleam using rustc 1.32.0 which shows the error at the bottom.

This might be the same as #55779 although this seems specific to macOS so might be different.
@staktrace staktrace mentioned this issue Feb 9, 2019
Open
@jonas-schievink jonas-schievink added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Feb 9, 2019
@wirelyre
Copy link

wirelyre commented Feb 9, 2019

This seems to be related to a large #[derive(Clone)] struct from gl_generator. Reduced test case.

@wirelyre
Copy link

wirelyre commented Feb 9, 2019 •
edited
Loading

I cannot reproduce the compiler stack overflow on beta or nightly (2019-02-02).

@Centril Centril added the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Mar 10, 2020
@Centril Centril added the E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example label Mar 20, 2020
@rylev rylev mentioned this issue Mar 20, 2020
Merged
Centril pushed a commit to Centril/rust that referenced this issue Mar 21, 2020
@rylev
Add tests for rust-lang#58319 and rust-lang#65131
5444ade
Centril added a commit to Centril/rust that referenced this issue Mar 21, 2020
@Centril
Rollup merge of rust-lang#70176 - rylev:ice-tests, r=Centril
9fe4fab 
Add tests for rust-lang#58319 and rust-lang#65131

Fixes rust-lang#58319 and fixes rust-lang#65131
@Centril Centril mentioned this issue Mar 21, 2020
Closed
@Centril Centril mentioned this issue Mar 21, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 21, 2020
@bors
Auto merge of rust-lang#70205 - Centril:rollup-0jq9k4s, r=Centril
5f13820 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#65097 (Make std::sync::Arc compatible with ThreadSanitizer)
 - rust-lang#69033 (Use generator resume arguments in the async/await lowering)
 - rust-lang#69997 (add `Option::{zip,zip_with}` methods under "option_zip" gate)
 - rust-lang#70038 (Remove the call that makes miri fail)
 - rust-lang#70058 (can_begin_literal_maybe_minus: `true` on `"-"? lit` NTs.)
 - rust-lang#70111 (BTreeMap: remove shared root)
 - rust-lang#70139 (add delay_span_bug to TransmuteSizeDiff, just to be sure)
 - rust-lang#70165 (Remove the erase regions MIR transform)
 - rust-lang#70166 (Derive PartialEq, Eq and Hash for RangeInclusive)
 - rust-lang#70176 (Add tests for rust-lang#58319 and rust-lang#65131)
 - rust-lang#70177 (Fix oudated comment for NamedRegionMap)
 - rust-lang#70184 (expand_include: set `.directory` to dir of included file.)
 - rust-lang#70187 (more clippy fixes)
 - rust-lang#70188 (Clean up E0439 explanation)
 - rust-lang#70189 (Abi::is_signed: assert that we are a Scalar)
 - rust-lang#70194 (#[must_use] on split_off())

Failed merges:

r? @ghost
@bors bors closed this as completed in 855eac3 Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for #58319 and #65131 rylev/rust
4 participants
@staktrace @Centril @jonas-schievink @wirelyre