Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#60586 #60623

Closed
rust-highfive opened this issue May 8, 2019 · 0 comments · Fixed by #60626
Closed

rls no longer builds after rust-lang/rust#60586 #60623

rust-highfive opened this issue May 8, 2019 · 0 comments · Fixed by #60626
Assignees
@Xanewok @cramertj
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60586, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @cramertj, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 8, 2019
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue May 8, 2019
@matthiaskrgr
rustup rust-lang/rust#60586
857c2c5 
cc rust-lang/rust#60623
@matthiaskrgr matthiaskrgr mentioned this issue May 8, 2019
Merged
bors added a commit to rust-lang/rust-clippy that referenced this issue May 8, 2019
@bors
Auto merge of #4068 - matthiaskrgr:rustup_3, r=Manishearth
341c96a 
rustup rust-lang/rust#60586

cc rust-lang/rust#60623

changelog: none
@matthiaskrgr matthiaskrgr mentioned this issue May 8, 2019
Merged
bors added a commit that referenced this issue May 8, 2019
@bors
Auto merge of #60626 - matthiaskrgr:submodule_upd, r=oli-obk
e630580 
submodules: update clippy from fc96aa0 to 341c96a

Fixes clippy toolstate

Fixes #60623

Changes:
````
rustup #60586
Add test for #771.
Clean up while_loop tests
````

r? @Manishearth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

@cramertj cramertj

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy from fc96aa03 to 341c96af matthiaskrgr/rust
3 participants
@Xanewok @cramertj @rust-highfive