Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement rustc::ty:print::obsolete with custom PrettyPrinter #61139

Closed
mark-i-m opened this issue May 24, 2019 · 2 comments · Fixed by #76027
Closed

Reimplement rustc::ty:print::obsolete with custom PrettyPrinter #61139

mark-i-m opened this issue May 24, 2019 · 2 comments · Fixed by #76027
Assignees
@davidtwco
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@mark-i-m
Copy link
Member

mark-i-m commented May 24, 2019 •
edited
Loading

As per @eddyb in #61062 (comment)
@mark-i-m
Copy link
Member Author

@rustbot modify labels: +C-cleanup

@rustbot rustbot added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label May 24, 2019
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 24, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 22, 2019
Closed
@steveklabnik
Copy link
Member

Triage: it's been over a year, and it looks like maybe this function doesn't even exist anymore?

@davidtwco davidtwco mentioned this issue Aug 28, 2020
Merged
@davidtwco davidtwco self-assigned this Aug 28, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 30, 2020
@Dylan-DPC
Rollup merge of rust-lang#76027 - davidtwco:issue-61139-remove-obsole…
10fb8d4 
…te-pretty-printer, r=eddyb

ty: remove obsolete pretty printer

Fixes rust-lang#61139.

This PR removes the obsolete printer and replaces all uses of it with `FmtPrinter`. Of the replaced uses, all but one use was in `debug!` logging, two cases were notable:

- `MonoItem::to_string` is used in `-Z print-mono-items` and therefore affects the output of all codegen-units tests (which have been updated).
- `DefPathBasedNames` was used in `librustc_codegen_llvm/type_of.rs` with `LLVMStructCreateNamed` and that'll now get different values, but nothing will break as a result of this.

cc @eddyb (whom I've discussed this with)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 31, 2020
@Dylan-DPC
Rollup merge of rust-lang#76027 - davidtwco:issue-61139-remove-obsole…
0af6fed 
…te-pretty-printer, r=eddyb

ty: remove obsolete pretty printer

Fixes rust-lang#61139.

This PR removes the obsolete printer and replaces all uses of it with `FmtPrinter`. Of the replaced uses, all but one use was in `debug!` logging, two cases were notable:

- `MonoItem::to_string` is used in `-Z print-mono-items` and therefore affects the output of all codegen-units tests (which have been updated).
- `DefPathBasedNames` was used in `librustc_codegen_llvm/type_of.rs` with `LLVMStructCreateNamed` and that'll now get different values, but nothing will break as a result of this.

cc @eddyb (whom I've discussed this with)
@bors bors closed this as completed in 8ed5cb5 Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidtwco davidtwco

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ty: remove obsolete pretty printer davidtwco/rust
5 participants
@steveklabnik @davidtwco @jonas-schievink @mark-i-m @rustbot