Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json output in log when doing x.py check #71561

Closed
matthiaskrgr opened this issue Apr 25, 2020 · 0 comments · Fixed by #71567
Closed

json output in log when doing x.py check #71561

matthiaskrgr opened this issue Apr 25, 2020 · 0 comments · Fixed by #71567
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

When doing x.py check, it looks like there is some json output/debug message that might not belong there:

    Checking test v0.0.0 (/home/matthias/vcs/github/rust/src/libtest)
    Finished release [optimized] target(s) in 10.48s
{"reason":"build-finished","success":true}
Checking compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Checking lazy_static v1.4.0

    Finished release [optimized] target(s) in 1m 23s
{"reason":"build-finished","success":true}
Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Checking lazy_static v1.4.0

This was caused by 659951c
cc @Mark-Simulacrum
@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Apr 25, 2020
@jonas-schievink jonas-schievink added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 25, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Apr 25, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 27, 2020
@Dylan-DPC
Rollup merge of rust-lang#71567 - Mark-Simulacrum:no-success, r=matth…
76a51c0 
…iaskrgr

Handle build completion message from Cargo

This was introduced in the recent bump to 1.44 bootstrap cargo

Fixes rust-lang#71561.
@jonas-schievink jonas-schievink mentioned this issue Apr 27, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#71567 - Mark-Simulacrum:no-success, r=matth…
0dd004d 
…iaskrgr

Handle build completion message from Cargo

This was introduced in the recent bump to 1.44 bootstrap cargo

Fixes rust-lang#71561.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#71567 - Mark-Simulacrum:no-success, r=matth…
7f69ee6 
…iaskrgr

Handle build completion message from Cargo

This was introduced in the recent bump to 1.44 bootstrap cargo

Fixes rust-lang#71561.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Apr 29, 2020
@Dylan-DPC
Rollup merge of rust-lang#71567 - Mark-Simulacrum:no-success, r=matth…
d35aab9 
…iaskrgr

Handle build completion message from Cargo

This was introduced in the recent bump to 1.44 bootstrap cargo

Fixes rust-lang#71561.
RalfJung added a commit to RalfJung/rust that referenced this issue Apr 30, 2020
@RalfJung
Rollup merge of rust-lang#71567 - Mark-Simulacrum:no-success, r=matth…
91428ab 
…iaskrgr

Handle build completion message from Cargo

This was introduced in the recent bump to 1.44 bootstrap cargo

Fixes rust-lang#71561.
@bors bors closed this as completed in 01fffff May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle build completion message from Cargo Mark-Simulacrum/rust
2 participants
@matthiaskrgr @jonas-schievink