Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n templates automatically #7850

Closed
omasanori opened this issue Jul 17, 2013 · 5 comments
Closed

Update l10n templates automatically #7850

omasanori opened this issue Jul 17, 2013 · 5 comments

Comments

@omasanori
Copy link
Contributor

Updating .po templates by hand will cause irrelevant conflicts since .pot file includes information of creation time. For example, two translators runs make docs-l10n in their own working tree, and then conflicts may occur even if the content of base (English) document is the same.

IMHO it's better to update automatically once a day/week/month or so, or when every commit changing docs/*.md is merged (always up-to-date, but maybe verbose when you read git log). It may also help non-translator documentation writers.

@pnkfelix
Copy link
Member

visiting for triage, email from 2013 sep 09.

I'll admit, I'm not an expert in this area. I assume we're checking in build products (rather than building them as part of our internal process) because ... we don't want to introduce a prerequisite on the tools used by make docs-i10n? Is that right, or am I missing something here?

@omasanori
Copy link
Contributor Author

@pnkfelix Yes, I think that we don't want to force anyone to install tools for localization when he/she just want to hack some language-neutral part of the tree.

However, updating by translators also leads to some pain, so we may need a better solution.
(for example, .pots are updated only by any bot and translators use latest .pots even if the base document is updated after .pots update.)

@emberian
Copy link
Member

Visiting for triage. I have no idea what needs to happen for this.

@omasanori
Copy link
Contributor Author

@cmr Now, .pot files are ignored and not included. I think this issue has been resolved.

@omasanori
Copy link
Contributor Author

Thanks!

flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 4, 2021
…amsteffen

Fix FP: no lint when cast is coming from `signum` method call for `cast_possible_truncation` lint

Fixes a FP when cast is coming from `signum` method call

fixes: rust-lang#5395

changelog: [`cast_possible_truncation`] Fix FP when cast is coming from `signum` method call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants