Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target_env should not include ABI information #78791

Closed
cuviper opened this issue Nov 5, 2020 · 0 comments · Fixed by #119590
Closed

target_env should not include ABI information #78791

cuviper opened this issue Nov 5, 2020 · 0 comments · Fixed by #119590
Labels
A-target-specs Area: compile-target specifications C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-freebsd Operating system: FreeBSD O-netbsd Operating system: NetBSD T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@cuviper
Copy link
Member

cuviper commented Nov 5, 2020

There are a few tier-3 targets that have ABI descriptors in their target_env.

compiler/rustc_target/src/spec/armv6_unknown_freebsd.rs:13:        target_env: "gnueabihf".to_string(),
compiler/rustc_target/src/spec/armv6_unknown_netbsd_eabihf.rs:14:        target_env: "eabihf".to_string(),
compiler/rustc_target/src/spec/armv7_unknown_freebsd.rs:13:        target_env: "gnueabihf".to_string(),
compiler/rustc_target/src/spec/armv7_unknown_netbsd_eabihf.rs:13:        target_env: "eabihf".to_string(),

The precedent from other targets is that these should be just "gnu" or an empty string. This came up in the RFC for target_abi, rust-lang/rfcs#2992 (comment), where I'd expect these targets will have target_abi: "eabihf".
@cuviper cuviper added O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-freebsd Operating system: FreeBSD O-netbsd Operating system: NetBSD A-target-specs Area: compile-target specifications C-bug Category: This is a bug. labels Nov 5, 2020
@cuviper cuviper mentioned this issue Nov 5, 2020
Merged
@KodrAus KodrAus mentioned this issue Jan 13, 2021
Closed
4 tasks
@madsmtm madsmtm mentioned this issue Feb 24, 2024
Merged
@bors bors closed this as completed in e13f454 Feb 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 25, 2024
@rust-timer
Unrolled build for rust-lang#119590
fd342c1 
Rollup merge of rust-lang#119590 - ChrisDenton:cfg-target-abi, r=Nilstrieb

Stabilize `cfg_target_abi`

This stabilizes the `cfg` option called `target_abi`:

```rust
#[cfg(target_abi = "eabihf")]
```

Tracking issue: rust-lang#80970

fixes rust-lang#78791
resolves rust-lang#80970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-target-specs Area: compile-target specifications C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-freebsd Operating system: FreeBSD O-netbsd Operating system: NetBSD T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize cfg_target_abi ChrisDenton/rust
1 participant
@cuviper