rustc_target: Update some old naming around self contained linking #100126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
luqmana
reviewed
Aug 5, 2022
| "mingw" => CrtObjectsFallback::Mingw, | ||
| "wasm" => CrtObjectsFallback::Wasm, | ||
| "false" => LinkSelfContainedDefault::False, | ||
| "true" | "wasm" => LinkSelfContainedDefault::True, |
There was a problem hiding this comment.
Is the wasm case here for back-compat for any out-of-tree target specs?
There was a problem hiding this comment.
I doubt that it's used anywhere, but I just kept full backward compatibility for all options for now.
|
+1 This naming makes the option a lot less confusing. LGTM |
|
r? compiler |
petrochenkov
commented
Aug 7, 2022
| /// Same as `(pre|post)_link_objects`, but when self-contained linking mode is enabled. | ||
| pub pre_link_objects_self_contained: CrtObjects, | ||
| pub post_link_objects_self_contained: CrtObjects, | ||
| pub link_self_contained_default: LinkSelfContainedDefault, |
There was a problem hiding this comment.
Suggested change
| pub link_self_contained_default: LinkSelfContainedDefault, | |
| pub link_self_contained: LinkSelfContainedDefault, |
Large number of target options target.foo provide defaults for something that can also be user-specified -Cfoo=override, and almost none of them uses the _default suffix.
|
r? compiler |
davidtwco
approved these changes
Aug 9, 2022
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 10, 2022
rustc_target: Update some old naming around self contained linking The "fallback" naming pre-dates introduction of `-Clink-self-contained`. Noticed when reviewing rust-lang#99500. This PR doesn't break any json target spec, but supporting per-linker-flavor startup objects needed by rust-lang#99500 will break them, so maybe next time I'll remove the compatibility names.
This comment was marked as resolved.
This comment was marked as resolved.
bors
added
S-waiting-on-author
The "fallback" naming pre-dates introduction of `-Clink-self-contained`
|
@bors r=davidtwco |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 13, 2022
rustc_target: Update some old naming around self contained linking The "fallback" naming pre-dates introduction of `-Clink-self-contained`. Noticed when reviewing rust-lang#99500. This PR doesn't break any json target spec, but supporting per-linker-flavor startup objects needed by rust-lang#99500 will break them, so maybe next time I'll remove the compatibility names.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 14, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#99582 (Delay a span bug if we see ty/const generic params during writeback) - rust-lang#99861 (orphan check: rationalize our handling of constants) - rust-lang#100026 (Add `Iterator::array_chunks` (take N+1)) - rust-lang#100115 (Suggest removing `let` if `const let` or `let const` is used) - rust-lang#100126 (rustc_target: Update some old naming around self contained linking) - rust-lang#100487 (`assert_{inhabited,zero_valid,uninit_valid}` intrinsics are safe) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "fallback" naming pre-dates introduction of
-Clink-self-contained.Noticed when reviewing #99500.
This PR doesn't break any json target spec, but supporting per-linker-flavor startup objects needed by #99500 will break them, so maybe next time I'll remove the compatibility names.