Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser will not suggest invalid expression when use public #100188

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Parser will not suggest invalid expression when use public #100188

merged 1 commit into from
Aug 25, 2022

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Aug 6, 2022 •
edited by compiler-errors
Loading

Fixes #100165

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 6, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2022
@chenyukang
Copy link
Member Author

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned oli-obk Aug 6, 2022
gimbling-away
gimbling-away suggested changes Aug 7, 2022
View reviewed changes
compiler/rustc_ast/src/token.rs Outdated Show resolved Hide resolved
@gimbling-away
Copy link
Contributor

@chenyukang Remember to squash your commits 👏🏻

@chenyukang
Copy link
Member Author

@chenyukang Remember to squash your commits 👏🏻
thanks for remind, done!

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2022

📌 Commit 863488d has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Aug 20, 2022
@ChrisDenton
Rollup merge of rust-lang#100188 - chenyukang:fix-issue-100165, r=est…
8497248 
…ebank

Parser will not suggest invalid expression when use public

Fixes rust-lang#100165
@ChrisDenton ChrisDenton mentioned this pull request Aug 20, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Aug 20, 2022
@Dylan-DPC
Rollup merge of rust-lang#100188 - chenyukang:fix-issue-100165, r=est…
fbb575b 
…ebank

Parser will not suggest invalid expression when use public

Fixes rust-lang#100165
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 20, 2022
Closed
This was referenced Aug 20, 2022
Closed
Closed
@bors
Copy link
Contributor

bors commented Aug 20, 2022

☔ The latest upstream changes (presumably #100793) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 20, 2022
@estebank
Copy link
Contributor

You'll have to rebase on top of a more recent version of the repo before we can merge.

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2022

Some changes occurred in src/tools/cargo

cc @ehuss

The Miri submodule was changed

cc @rust-lang/miri

@chenyukang
Copy link
Member Author

ooo, seems pushed some extra changes, let me fix it.

@chenyukang
Copy link
Member Author

Some changes occurred in src/tools/cargo

cc @ehuss

The Miri submodule was changed

cc @rust-lang/miri

Please ignore it.

@bors
Copy link
Contributor

bors commented Aug 23, 2022

☔ The latest upstream changes (presumably #100904) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2022

📌 Commit 351acc8 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 24, 2022
@JohnTitor
Rollup merge of rust-lang#100188 - chenyukang:fix-issue-100165, r=est…
e21c1e4 
…ebank

Parser will not suggest invalid expression when use public

Fixes rust-lang#100165
This was referenced Aug 24, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2022
@bors
Auto merge of rust-lang#100977 - JohnTitor:rollup-8hc7rxh, r=JohnTitor
9b9bc63 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99332 (Stabilize `#![feature(label_break_value)]`)
 - rust-lang#99954 (let-else: break out to one scope higher for let-else)
 - rust-lang#100188 (Parser will not suggest invalid expression when use public)
 - rust-lang#100780 (save_analysis: Migrate diagnostic)
 - rust-lang#100808 (Migrate `rustc_interface` diagnostics )
 - rust-lang#100921 (Add a warning about `Option/Result::and()` being eagerly evaluated)
 - rust-lang#100960 (rustdoc: ayu code color selector more specific)
 - rust-lang#100964 (Sync rustc_codegen_cranelift)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed8cfc8 into rust-lang:master Aug 25, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 25, 2022
@chenyukang chenyukang mentioned this pull request Sep 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gimbling-away gimbling-away gimbling-away requested changes

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

Suggest invalid expression when use public
7 participants
@chenyukang @rust-highfive @gimbling-away @estebank @bors @rustbot @oli-obk