Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use start_point instead of next_point to point to elided lifetime amp… #100230

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Aug 7, 2022

Using next_point creates a span which points inside the multibyte token, ICEing.

Fixes #100224

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 7, 2022
@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2022
@compiler-errors
Copy link
Member

r? @compiler-errors
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2022

📌 Commit f6af4ef has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#100019 (Revive suggestions for boxed trait objects instead of impl Trait)
 - rust-lang#100038 (Document the `no-std` target option in config.toml.example)
 - rust-lang#100194 (Remove even more box syntax uses from src/test)
 - rust-lang#100206 (test: skip terminfo parsing in Miri)
 - rust-lang#100230 (Use start_point instead of next_point to point to elided lifetime amp…)
 - rust-lang#100244 (Add armv4t-none-eabi take2)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5648add into rust-lang:master Aug 8, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 8, 2022
@cjgillot cjgillot deleted the noice-multibyte-amp branch August 8, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: due to certain invalid function definitions (nightly)
6 participants