Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy generics from functions to Return Position Impl Traits in HIR lowering #101345

Closed
wants to merge 53 commits into from
Closed

Copy generics from functions to Return Position Impl Traits in HIR lowering #101345

wants to merge 53 commits into from

Commits on Sep 2, 2022

  1. Set up new approach for impl trait in return position 

    Adds a feature flag to use the new code only in certain tests to be able
to make progress step by step.
    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    7bbe7b6 View commit details
    Browse the repository at this point in the history

  2. Make RPIT not inherit generics from its function

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    b3cc702 View commit details
    Browse the repository at this point in the history

  3. Call mk_param_from_def for all params

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    bae1deb View commit details
    Browse the repository at this point in the history

  4. Copy generic parameters from function to impl trait opaque type

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a5f8780 View commit details
    Browse the repository at this point in the history

  5. Test nested impl trait in return position

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    c1f8fbd View commit details
    Browse the repository at this point in the history

  6. Add generic type and const args to OpaqueDef

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    2cccbc4 View commit details
    Browse the repository at this point in the history

  7. Handle all kind of generic args when converting to ty

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    bb28711 View commit details
    Browse the repository at this point in the history

  8. param_env def_id is the one of the opaque type for RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    f60f609 View commit details
    Browse the repository at this point in the history

  9. Properly gather explicit predicates of opaque type

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a71699d View commit details
    Browse the repository at this point in the history

  10. is_impl_trait_defn doesn't have any effect now with RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a311717 View commit details
    Browse the repository at this point in the history

  11. register_member_constraints is 0 for RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    4642ec9 View commit details
    Browse the repository at this point in the history

  12. gather_explicit_predicates_of return empty for OpaqueTyOrigin::AsyncFn

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    35a98a7 View commit details
    Browse the repository at this point in the history

  13. Properly type check type parameter predicates for RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    fee7dc6 View commit details
    Browse the repository at this point in the history

  14. Properly handle Const generics

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    df9356d View commit details
    Browse the repository at this point in the history

  15. Pass Generics to lower impl trait instead of generic params 

    We're going to need where clauses too.
    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    79eeffa View commit details
    Browse the repository at this point in the history

  16. Copy generic param bounds and where clauses from function to RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d102712 View commit details
    Browse the repository at this point in the history

  17. Remap on lower_res

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8d26963 View commit details
    Browse the repository at this point in the history

  18. Lower lifetime bounds/predicates as static if not part of RPIT bounds

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a08ff68 View commit details
    Browse the repository at this point in the history

  19. Add APIT test for RPIT v2

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    cce5412 View commit details
    Browse the repository at this point in the history

  20. Add bounds regression test for RPIT v2

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    3b4ab9d View commit details
    Browse the repository at this point in the history

  21. Add generic associated type test for RPIT v2

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    be33fa2 View commit details
    Browse the repository at this point in the history

  22. Add where bounds test for RPIT v2

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    c67ab47 View commit details
    Browse the repository at this point in the history

  23. Lower APIT generics to RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    064675d View commit details
    Browse the repository at this point in the history

  24. Copy generic params from outer impl/trait blocks to RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    50bc776 View commit details
    Browse the repository at this point in the history

  25. Add debug call on rustc_middle generics

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8f20d42 View commit details
    Browse the repository at this point in the history

  26. Supress warn on artificial static lifetimes for RPIT

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    98d43e5 View commit details
    Browse the repository at this point in the history

  27. instrument type param predicates and bounds in generic fns

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    cfa73f8 View commit details
    Browse the repository at this point in the history

  28. Add APIT with lifetimes test

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9118087 View commit details
    Browse the repository at this point in the history

  29. Add a simple APIT test

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    3049a8d View commit details
    Browse the repository at this point in the history

  30. Add lifetimes bounds test

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8b5c082 View commit details
    Browse the repository at this point in the history

  31. Do not assert impl_trait_* is_empty

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    1563a66 View commit details
    Browse the repository at this point in the history

  32. Add debug information

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    54d5fa4 View commit details
    Browse the repository at this point in the history

  33. Add APIT anonymous lifetime test

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    faafdf1 View commit details
    Browse the repository at this point in the history

  34. Add trait bound anonymous lifetime test

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    fff4d31 View commit details
    Browse the repository at this point in the history

  35. Create definitions and remap lifetimes in lower_lifetime_binder

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    f08f19e View commit details
    Browse the repository at this point in the history

  36. save/restore the node-id table for poly-trait-ref 

    The "right thing" is probably to save/restore the binders.
    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    697393f View commit details
    Browse the repository at this point in the history

  37. impl/block types are first and then fn types

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9f8a343 View commit details
    Browse the repository at this point in the history

  38. Remove return_position_impl_trait_v2 feature flag and make it default

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    f514607 View commit details
    Browse the repository at this point in the history

  39. Remove reborrow in favor of passing &mut

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    25bbe2a View commit details
    Browse the repository at this point in the history

  40. Pass generics info from context down to the inner rpits on async fns

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    bab1d54 View commit details
    Browse the repository at this point in the history

  41. Push apit nodes before lowering generics and bounds

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a19d07e View commit details
    Browse the repository at this point in the history

  42. Do not create new defs and remaps when lowering Universal inside RPITs

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    679293a View commit details
    Browse the repository at this point in the history

  43. Only create def and remap on lower_lifetime_binder for RPITs and not … 

    …for async
    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    be98207 View commit details
    Browse the repository at this point in the history

  44. Ignore where-clauses wf checks for RPITs they are kinda bogus

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    f16d7fe View commit details
    Browse the repository at this point in the history

  45. Bless impl-trait-captures test as the output is better now

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    7200539 View commit details
    Browse the repository at this point in the history

  46. Bless async test

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a4356ee View commit details
    Browse the repository at this point in the history

  47. Bless bound-normalization-fail test

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    0791f8d View commit details
    Browse the repository at this point in the history

  48. Avoid unneeded repeated code

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8d53dc7 View commit details
    Browse the repository at this point in the history

  49. itertools is not needed anymore in rustc_ast_lowering

    @spastorino
    spastorino committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    49d057f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Add debug_asserts back

    @spastorino
    spastorino committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    0fadeed View commit details
    Browse the repository at this point in the history

  2. call lower_span before adding it to GenericArg::Type

    @spastorino
    spastorino committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    835d7de View commit details
    Browse the repository at this point in the history

  3. Move itctx creation to outside loop

    @spastorino
    spastorino committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    971641f View commit details
    Browse the repository at this point in the history

  4. Extend Rustdocs of lower_lifetime_binder

    @spastorino
    spastorino committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d45f1d3 View commit details
    Browse the repository at this point in the history