Rustdoc-Json: Add enum discriminant

[aDotInTheVoid]

Does the first part of #101337, by adding it to clean, but doesn't change HTML output, as

1. No Consensus has appeared on the UI for this
2. When inlining across crates, information is lost

JSON doesn't have either of these limitations.

r? @GuillaumeGomez

[rustbot]

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

[GuillaumeGomez]

Looks good to me. Let's make a perf run first.

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit b76a012 with merge 1d47f06959f0dd98dc00d4fcdf835a8791410ec9...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1d47f06959f0dd98dc00d4fcdf835a8791410ec9 (1d47f06959f0dd98dc00d4fcdf835a8791410ec9)

[rust-timer]

Queued 1d47f06959f0dd98dc00d4fcdf835a8791410ec9 with parent 84f0c3f, future comparison URL.

[rust-timer]

Finished benchmarking commit (1d47f06959f0dd98dc00d4fcdf835a8791410ec9): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.6%, 0.8%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[GuillaumeGomez]

It's a bit more than I expected. Considering it's only used for the JSON output, it seems to have a big impact on HTML output. Would it be possible to query this information on demand instead of storing it?

[aDotInTheVoid]

@bors try @rust-timer queue

[bors]

@aDotInTheVoid: 🔑 Insufficient privileges: not in try users

[rust-timer]

Insufficient permissions to issue commands to rust-timer.

[GuillaumeGomez]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit efbd8f6 with merge 4296b71ebf7432355171670548dc32058a5e9f5d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 4296b71ebf7432355171670548dc32058a5e9f5d (4296b71ebf7432355171670548dc32058a5e9f5d)

[rust-timer]

Queued 4296b71ebf7432355171670548dc32058a5e9f5d with parent 8521a8c, future comparison URL.

[rust-timer]

Finished benchmarking commit (4296b71ebf7432355171670548dc32058a5e9f5d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-2.8%	[-3.0%, -2.6%]	2
All ❌✅ (primary)	0.6%	[-2.0%, 3.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

1. the arithmetic mean of the percent change ↩

2. number of relevant changes ↩

[GuillaumeGomez]

Seems all good now. The impact on rss is expected unfortunately, but not much we can do. Thanks for working on this!

@bors r+ rollup=iffy

[bors]

📌 Commit efbd8f6 has been approved by GuillaumeGomez

It is now in the queue for this repository.

[bors]

⌛ Testing commit efbd8f6 with merge 406e03f...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 406e03f to master...