Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize #![feature(mixed_integer_ops)] #101555

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Stabilize #![feature(mixed_integer_ops)] #101555

merged 1 commit into from
Sep 28, 2022

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Sep 8, 2022

Tracked and FCP completed in #87840.

@rustbot label +T-libs-api +S-waiting-on-review +relnotes

r? rust-lang/t-libs-api

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 8, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 8, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2022
@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 8, 2022
@Dylan-DPC
Copy link
Member

Oh i actually had #98345 open for this but no worries if you wanna go ahead with this I could close that

@jhpratt
Copy link
Member Author

jhpratt commented Sep 8, 2022

Ah, I didn't realize that. Either way works for me: in theory the PRs should be identical.

@joshtriplett
Copy link
Member

@Dylan-DPC That PR is delegated to you, and it looks ready to be merged. Any blockers for doing so?

@Dylan-DPC
Copy link
Member

No blockers just dint have the time to update the since field to the new placholder

@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 27, 2022

📌 Commit 5510a69 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 27, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 27, 2022
@Dylan-DPC
Rollup merge of rust-lang#101555 - jhpratt:stabilize-mixed_integer_op…
bde14a3 
…s, r=joshtriplett

Stabilize `#![feature(mixed_integer_ops)]`

Tracked and FCP completed in rust-lang#87840.

`@rustbot` label +T-libs-api +S-waiting-on-review +relnotes

r? rust-lang/t-libs-api
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 27, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 27, 2022
@Dylan-DPC
Rollup merge of rust-lang#101555 - jhpratt:stabilize-mixed_integer_op…
fa37cdb 
…s, r=joshtriplett

Stabilize `#![feature(mixed_integer_ops)]`

Tracked and FCP completed in rust-lang#87840.

``@rustbot`` label +T-libs-api +S-waiting-on-review +relnotes

r? rust-lang/t-libs-api
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 27, 2022
Closed
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Sep 27, 2022
@fee1-dead
Rollup merge of rust-lang#101555 - jhpratt:stabilize-mixed_integer_op…
cbac908 
…s, r=joshtriplett

Stabilize `#![feature(mixed_integer_ops)]`

Tracked and FCP completed in rust-lang#87840.

```@rustbot``` label +T-libs-api +S-waiting-on-review +relnotes

r? rust-lang/t-libs-api
@fee1-dead fee1-dead mentioned this pull request Sep 27, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2022
@bors
Auto merge of rust-lang#102377 - matthiaskrgr:rollup-1zvj50t, r=matth…
90c34fa 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101555 (Stabilize `#![feature(mixed_integer_ops)]`)
 - rust-lang#102253 (rustdoc: use CSS containment to speed up render)
 - rust-lang#102281 (make invalid_value lint a bit smarter around enums)
 - rust-lang#102284 (Structured suggestion for missing `mut`/`const` in raw pointer)
 - rust-lang#102330 (rustdoc: remove no-op CSS `.srclink { font-weight; font-size }`)
 - rust-lang#102337 (Avoid LLVM-deprecated `Optional::hasValue`)
 - rust-lang#102356 (session: remove now-unnecessary lint `#[allow]`s)
 - rust-lang#102367 (rustdoc: remove redundant `#help-button` CSS)
 - rust-lang#102369 (Fix search result colors)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ad57d5f into rust-lang:master Sep 28, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 28, 2022
@jhpratt jhpratt deleted the stabilize-mixed_integer_ops branch September 28, 2022 01:39
@JohnTitor JohnTitor mentioned this pull request Sep 28, 2022
Closed
3 tasks
@newAM newAM mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jhpratt @rustbot @rust-highfive @Dylan-DPC @joshtriplett @bors