Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: Fix #50619 (again) and add a regression test #105638

Merged
merged 3 commits into from
Dec 18, 2022
Merged

fs: Fix #50619 (again) and add a regression test #105638

merged 3 commits into from
Dec 18, 2022

Commits on Dec 12, 2022

  1. fs: Fix rust-lang#50619 (again) and add a regression test 

    Bug rust-lang#50619 was fixed by adding an end_of_stream flag in rust-lang#50630.
Unfortunately, that fix only applied to the readdir_r() path.  When I
switched Linux to use readdir() in rust-lang#92778, I inadvertently reintroduced
the bug on that platform.  Other platforms that had always used
readdir() were presumably never fixed.

This patch enables end_of_stream for all platforms, and adds a
Linux-specific regression test that should hopefully prevent the bug
from being reintroduced again.
    @tavianator
    tavianator committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ba4dd46 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. fs/tests: Explicitly kill the zombie rather than sleeping until it dies

    @tavianator
    tavianator committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    1550a25 View commit details
    Browse the repository at this point in the history

  2. fs/tests: Fail fast on duplicate errors rather than looping indefinitely

    @tavianator
    tavianator committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9fb7c5a View commit details
    Browse the repository at this point in the history