Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve pin docs #105902

Merged
merged 1 commit into from
Dec 20, 2022
Merged

docs: improve pin docs #105902

merged 1 commit into from
Dec 20, 2022

Conversation

vincenzopalazzo
Copy link
Member

@vincenzopalazzo vincenzopalazzo commented Dec 19, 2022 •
edited
Loading

Override #104195 with a full cleanup of the git history, now it should be ready to be merged.

r? @eholk

@rustbot label +A-async-await

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 19, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the A-async-await Area: Async & Await label Dec 19, 2022
@rustbot rustbot assigned eholk and unassigned thomcc Dec 19, 2022
@Dylan-DPC
Copy link
Member

This was approved here so approving

@bors r=eholk rollup

@bors
Copy link
Contributor

bors commented Dec 19, 2022

📌 Commit 7fc6b0c has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 19, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 19, 2022
@matthiaskrgr
Rollup merge of rust-lang#105902 - vincenzopalazzo:macros/pin_docs, r…
90eb8ab 
…=eholk

docs: improve pin docs

Override rust-lang#104195 with a full cleanup of the git history, now it should be ready to be merged.

r? `@eholk`

`@rustbot` label +A-async-await
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2022
@bors
Auto merge of rust-lang#105918 - matthiaskrgr:rollup-mmazd62, r=matth…
c43bc13 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105801 (Realistic `Path::as_mut_os_str` doctest)
 - rust-lang#105860 (Add long error docs for `E0460` and `E0457`)
 - rust-lang#105895 (Test that we don't add a new kind of breaking change with TAITs)
 - rust-lang#105902 (docs: improve pin docs)
 - rust-lang#105910 (Update books)
 - rust-lang#105913 (rustdoc: remove width-limiter from source pages, stop overriding CSS)
 - rust-lang#105915 (Revert "Replace usage of `ResumeTy` in async lowering with `Context`")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a81d0dc into rust-lang:master Dec 20, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 20, 2022
@vincenzopalazzo vincenzopalazzo deleted the macros/pin_docs branch December 20, 2022 08:34
@vincenzopalazzo vincenzopalazzo mentioned this pull request Dec 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eholk eholk

Labels
A-async-await Area: Async & Await S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
7 participants
@vincenzopalazzo @rustbot @Dylan-DPC @bors @eholk @thomcc @ch-iv