Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type-directed probing for inherent associated types #105961

Merged
merged 11 commits into from
Feb 20, 2023
Merged

Type-directed probing for inherent associated types #105961

merged 11 commits into from
Feb 20, 2023

Commits on Feb 19, 2023

  1. Type-directed probing for inherent associated types

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    488d0c9 View commit details
    Browse the repository at this point in the history

  2. Use the correct ParamEnv

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    aa7edf7 View commit details
    Browse the repository at this point in the history

  3. Make use of ObligationCtxt

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    cc65ebd View commit details
    Browse the repository at this point in the history

  4. Groundwork for detecting ambiguous candidates 

    NB: Since we are using the same InferCtxt in each iteration,
we essentially *spoil* the inference variables and we only
ever get at most *one* applicable candidate (only the 1st candidate
has clean variables that can still unify correctly).
    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    b5e73bf View commit details
    Browse the repository at this point in the history

  5. Switch from for-loop to filter_map

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    3dc38fb View commit details
    Browse the repository at this point in the history

  6. Use InferCtxt::probe to properly detect ambiguous candidates

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    6065867 View commit details
    Browse the repository at this point in the history

  7. Fix substitution bug

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    77ea90e View commit details
    Browse the repository at this point in the history

  8. Add a test and several known bugs

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    6eb6455 View commit details
    Browse the repository at this point in the history

  9. Deduplicate fresh_item_substs

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    569ca2b View commit details
    Browse the repository at this point in the history

  10. Collect fulfillment errors across impls

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    00b976a View commit details
    Browse the repository at this point in the history

  11. Add some FIXMEs for follow-up PRs

    @fmease
    fmease committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    f2253da View commit details
    Browse the repository at this point in the history