Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a more helpful error for "trimmed_def_paths constructed" #106057

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Give a more helpful error for "trimmed_def_paths constructed" #106057

merged 1 commit into from
Dec 23, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 22, 2022

cc https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/ice.20debugging/near/315928294, #106056

@mejrs do you think this would have helped you figure out the problem faster?

@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2022

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 22, 2022
@compiler-errors
Copy link
Member

Might be worth also mentioning DelayDm

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Dec 22, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@jyn514 jyn514 removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Dec 22, 2022
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 22, 2022

📌 Commit e433029 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2022
@bors
Auto merge of rust-lang#106070 - matthiaskrgr:rollup-jv9ctkl, r=matth…
5e656ba 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105978 (Mark `proc_macro_decls_static` as always used)
 - rust-lang#106051 (Allow building std with cranelift)
 - rust-lang#106056 (Make `sess.bug` much less noisy)
 - rust-lang#106057 (Give a more helpful error for "trimmed_def_paths constructed")
 - rust-lang#106058 (Fix the issue number in comment for as_local_call_operand)
 - rust-lang#106059 (Avoid running the `Profile` step twice on `x setup`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit da370fe into rust-lang:master Dec 23, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 23, 2022
@jyn514 jyn514 deleted the trimmed-def-paths-ice branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jyn514 @rustbot @compiler-errors @bors