Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[drop tracking] Visit break expressions #106699

Merged
merged 2 commits into from
Jan 20, 2023
Merged

[drop tracking] Visit break expressions #106699

merged 2 commits into from
Jan 20, 2023

Commits on Jan 12, 2023

  1. Add a test case for rust-lang#102383

    @eholk
    eholk committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    96de375 View commit details
    Browse the repository at this point in the history

  2. [drop tracking] Visit break expressions 

    This fixes rust-lang#102383 by remembering to visit the expression in
`break expr` when building the drop tracking CFG. Missing this step was
causing an off-by-one error which meant after a number of awaits we'd be
looking for dropped values at the wrong point in the code.

Additionally, this changes the order of traversal for assignment
expressions to visit the rhs and then the lhs. This matches what is done
elsewhere.
    @eholk
    eholk committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d32f3fe View commit details
    Browse the repository at this point in the history