Add tests for configure.py #109267
Merged
Add tests for configure.py #109267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate out functions so that each unit test doesn't create a file on disk - Add a few unit tests Notably, verifying that we generate valid toml relies on python 3.11 so we can use `tomllib`.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
This also fixes a regression from rust-lang#106085 which stopped testing that we support python2 in PR CI.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109170 (Set `CMAKE_SYSTEM_NAME` for Linux targets) - rust-lang#109266 (rustdoc: Correctly merge import's and its target's docs in one more case) - rust-lang#109267 (Add tests for configure.py) - rust-lang#109273 (Make `slice::is_sorted_by` implementation nicer) - rust-lang#109277 (Fix generics_of for impl's RPITIT synthesized associated type) - rust-lang#109307 (Ignore `Inlined` spans when computing caller location.) - rust-lang#109364 (Only expect a GAT const param for `type_of` of GAT const arg) - rust-lang#109365 (Update mdbook) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 5, 2023
Move comment about python2 closer to the place it's used Addresses rust-lang#109267 (comment). r? `@pietroalbini`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I highly recommend reviewing this with whitespace disabled.
Notably, verifying that we generate valid toml relies on python 3.11 so
we can use
tomllib, so this also switchesx86_64-gnu-llvm-14(one of the PR builders) to use 3.11.While fixing that, I noticed that we stopped testing python2.7 support on PR CI in #106085. @fee1-dead @pietroalbini please be more careful in the future, there is no CI for CI itself that verifies we are testing everything we should be.