Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move us to the new large runners pool #109332

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Move us to the new large runners pool #109332

merged 1 commit into from
Mar 19, 2023

Conversation

Mark-Simulacrum
Copy link
Member

For now this keeps all the configuration identical (AFAICT) but we'll likely want to play with the specifics to move some of the slower builders to larger machines and the faster builders to smaller machines, likely reducing overall usage and improving CI times. I think we should leave that to later though, not worry about it just yet.

r? @pietroalbini

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 19, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pietroalbini
Copy link
Member

r=me with CI fixed

@pietroalbini
Copy link
Member

@bors r+ rollup=never p=10

@bors
Copy link
Contributor

bors commented Mar 19, 2023

📌 Commit 17bfe2d27a668f25e87a9c2232986c3b7bf807df has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2023
@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Mar 19, 2023
@bors
Copy link
Contributor

bors commented Mar 19, 2023

⌛ Testing commit 17bfe2d27a668f25e87a9c2232986c3b7bf807df with merge ad588e4376ffe0ce18b57db072761e27a1525e43...

@matthiaskrgr
Copy link
Member

Hmm, looks like 30 minutes in most of the jobs have not even started? 😕
image

@Mark-Simulacrum
Copy link
Member Author

Fixed. Missed a permission on the rust-lang-ci org.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member Author

@bors r-

We need the 2019 windows version, not latest, apparently. Multiple latest versions is confusing.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2023
@bors
Copy link
Contributor

bors commented Mar 19, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2023
@Mark-Simulacrum
Move us to the new large runners pool
f83dfd9 
For now this keeps all the configuration identical (AFAICT) but we'll
likely want to play with the specifics to move some of the slower
builders to larger machines and the faster builders to smaller machines,
likely reducing overall usage and improving CI times.
@Mark-Simulacrum
Copy link
Member Author

@bors r=pietroalbini rollup=never p=10

Moved back to windows-2019 (cc #92948).

@bors
Copy link
Contributor

bors commented Mar 19, 2023

📌 Commit f83dfd9 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 19, 2023
@bors
Copy link
Contributor

bors commented Mar 19, 2023

⌛ Testing commit f83dfd9 with merge da7c50c...

@bors
Copy link
Contributor

bors commented Mar 19, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing da7c50c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 19, 2023
@bors bors merged commit da7c50c into rust-lang:master Mar 19, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 19, 2023
@Mark-Simulacrum Mark-Simulacrum deleted the runner-switch branch March 19, 2023 22:50
This was referenced Mar 19, 2023
Closed
Closed
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (da7c50c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.4%, -0.3%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.3% [-0.4%, -0.3%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.7%, 1.0%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.6% [-3.1%, -1.2%] 4
Improvements ✅
(secondary)		 -2.6% [-5.0%, -0.7%] 76
All ❌✅ (primary) -1.1% [-3.1%, 1.0%] 7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.5%, 0.5%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [-0.6%, 0.5%] 4

@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 29, 2023
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.70.0, 1.69.0 Mar 29, 2023
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2023
@bors
Auto merge of rust-lang#109741 - Mark-Simulacrum:beta-backport, r=Mar…
6a97551 
…k-Simulacrum

[beta] backport

This PR backports:

- rust-lang#109332: Move us to the new large runners pool
- rust-lang#109156: Fix linker detection for clang with prefix
- rust-lang#109111: Create dirs for build_triple
- rust-lang#109094: Revert "enable ThinLTO for rustc on x86_64-pc-windows-msvc dist builds"

Also bumps us to the latest released stable, 1.68.2.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Mark-Simulacrum @rust-log-analyzer @pietroalbini @bors @matthiaskrgr @rust-timer @rustbot