fix typo in the creation of OpenOption for RustyHermit #109368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to this typo we have to build a workaround for issue hermit-os/kernel#191. RustyHermit is a tier 3 platform and backward compatibility does not have to be guaranteed.
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
I noticed that this workaround will @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 24, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108629 (rustdoc: add support for type filters in arguments and generics) - rust-lang#108924 (panic_immediate_abort requires abort as a panic strategy) - rust-lang#108961 (Refine error spans for const args in hir typeck) - rust-lang#108986 (sync LVI tests) - rust-lang#109142 (Add block-based mutex unlocking example) - rust-lang#109368 (fix typo in the creation of OpenOption for RustyHermit) - rust-lang#109493 (Return nested obligations from canonical response var unification) - rust-lang#109515 (Add AixLinker to support linking on AIX) - rust-lang#109536 (resolve: Rename some cstore methods to match queries and add comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors bot
added a commit
to hermit-os/hermit-rs
that referenced
this pull request
Apr 9, 2023
414: switch to the latest nightly compiler r=stlankes a=stlankes - the latest std library use random `HashMap` keys rust-lang/rust#107387 - fix typo in the creation of OpenOption for RustyHermit rust-lang/rust#109368 Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
bors bot
added a commit
to hermit-os/hermit-rs
that referenced
this pull request
Apr 9, 2023
414: switch to the latest nightly compiler r=stlankes a=stlankes - the latest std library use random `HashMap` keys rust-lang/rust#107387 - fix typo in the creation of OpenOption for RustyHermit rust-lang/rust#109368 Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
stlankes
added a commit
to stlankes/kernel
that referenced
this pull request
Apr 9, 2023
- since rust-lang/rust#109368 the workaround isn't longer required
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Apr 10, 2023
704: remove workaround, which fix wrong file flags r=stlankes a=stlankes - since rust-lang/rust#109368 the workaround isn't longer required Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
stlankes
added a commit
to stlankes/kernel
that referenced
this pull request
Apr 15, 2023
- since rust-lang/rust#109368 the workaround isn't longer required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this typo we have to build a workaround for issue hermit-os/kernel#191.
RustyHermit is a tier 3 platform and backward compatibility does not have to be guaranteed.