Use maybe_body_owned_by for multiple suggestions #113599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
chenyukang
changed the title
|
r? @cjgillot |
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-use-maybe_body_owned_by
branch
from
6b50fda
to
963958a
Compare
chenyukang
force-pushed
the
yukang-fix-use-maybe_body_owned_by
branch
from
963958a
to
1716016
Compare
cjgillot
reviewed
Jul 13, 2023
chenyukang
force-pushed
the
yukang-fix-use-maybe_body_owned_by
branch
from
4d2ab0e
to
5f8cef7
Compare
|
☔ The latest upstream changes (presumably #113637) made this pull request unmergeable. Please resolve the merge conflicts. |
chenyukang
force-pushed
the
yukang-fix-use-maybe_body_owned_by
branch
from
2d5ecb5
to
bdd04a6
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 14, 2023
…dy_owned_by, r=cjgillot Use maybe_body_owned_by for multiple suggestions This is a continued work from rust-lang#113567 We have several other suggestions not working for closure, this PR use `maybe_body_owned_by` to fix them and add test cases for them.
This was referenced Jul 14, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#113599 (Use maybe_body_owned_by for multiple suggestions) - rust-lang#113662 (Rename VecDeque's `rotate_left` and `rotate_right` parameters) - rust-lang#113681 (rustdoc-json: Add test for private supertrait.) - rust-lang#113682 (trait system refactor ping: also apply to nested modules of `solve`) - rust-lang#113685 (Print artifact sizes in `opt-dist`) - rust-lang#113688 (llvm-wrapper: update for LLVM API change) - rust-lang#113692 (tests: adapt for removal of -opaque-pointers in LLVM 17) - rust-lang#113698 (Make it clearer that we're just checking for an RPITIT) - rust-lang#113699 (update Miri) Failed merges: - rust-lang#113625 (Structurally normalize in selection) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continued work from #113567
We have several other suggestions not working for closure, this PR use
maybe_body_owned_byto fix them and add test cases for them.