Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make {Rc,Arc}::allocator associated functions #113810

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

glandium
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 18, 2023
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: #89132 (comment), that PR just landed a few hours ago.

I'm marking this prioritize since it fixes a (just recently introduced) namespace regression on types like Rc<Vec<T>> - but chance of that conflict is pretty small, so feel free to adjust if this isn't suitable.

@rustbot label +I-prioritize -T-libs +T-libs-api +A-allocators

@rustbot rustbot added A-allocators Area: Custom and system allocators I-prioritize Issue: Indicates that prioritization has been requested for this issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 18, 2023
@tgross35
Copy link
Contributor

r? libs-api

@tgross35
Copy link
Contributor

tgross35 commented Jul 18, 2023

Pretty easy to id but here's a repro

#![feature(allocator_api)]

use std::rc::Rc;

struct Foo;

impl Foo {
    fn allocator(&self) -> u32 { 100 }
}

fn main() {
    let rc = Rc::new(Foo);
    dbg!(rc.allocator());
}

Output on latest nightly:

warning: method `allocator` is never used
...
[foo.rs:15] rc.allocator() = Global

Output on older nightly:

[foo.rs:15] rc.allocator() = 100

@apiraino
Copy link
Contributor

@tgross35 we use the I-prioritize label for issues that need to be assigned a priority, not for patches (but thanks for raising the flag). If you are asking for an expedit review you might prefer talking with someone involved with #89132 (maybe open a topic on Zulip?) and assign to them.

@rustbot label -I-prioritize

@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 18, 2023
@tgross35
Copy link
Contributor

Whoops, "Indicates that prioritization has been requested for this issue" I can see why that can be read two different ways. In that case, @Amanieu reviewed the other PR so may want to do this one.

r? amanieu

@rustbot rustbot assigned Amanieu and unassigned joshtriplett Jul 18, 2023
@Amanieu
Copy link
Member

Amanieu commented Jul 20, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2023

📌 Commit b1398ca has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#113380 (style-guide: clean up "must"/"should"/"may")
 - rust-lang#113723 (Resurrect: rustc_llvm: Add a -Z `print-codegen-stats` option to expose LLVM statistics.)
 - rust-lang#113780 (Support `--print KIND=PATH` command line syntax)
 - rust-lang#113810 (Make {Rc,Arc}::allocator associated functions)
 - rust-lang#113907 (Minor improvements to Windows TLS dtors)

Failed merges:

 - rust-lang#113392 (style-guide: Some cleanups from the fmt-rfcs repo history)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5ac3684 into rust-lang:master Jul 21, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-allocators Area: Custom and system allocators S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants